test(bench): benchmark indexing in long strings 馃У - #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String indexing currently scans UTF-8 codepoints, but the benchmark suite had no coverage for reads from long strings. Add ASCII and Unicode programs that each perform 10,000 reads across the final four positions of a 131,072-codepoint string. The Unicode case mixes 1-, 2-, 3-, and 4-byte codepoints.
Both programs build the string by doubling, check the accumulated result, and are automatically picked up by the existing Criterion runner. They also work with
bench.sh.A local 10-sample Criterion run measured approximately 120 ms for ASCII and 298 ms for Unicode per program execution, including setup and interpreter overhead.
Validation:
cargo fmt --allcargo test --workspace --quietcargo bench -p benches --bench benchmark -- string_index --sample-size 10 --warm-up-time 1 --measurement-time 1AI disclosure: Codex authored the benchmark programs and this PR description.