GML-2083-TextFile-UnboundError : fix UnboundLocalError in community desc poll during rebuild#49
Open
prinskumar-tigergraph wants to merge 1 commit into
Open
Conversation
Return False and log full traceback when communities_have_desc (or embedding check) fails so the wait loop retries instead of crashing the rebuild TaskGroup.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Return False and log full traceback when communities_have_desc (or embedding check) fails so the wait loop retries instead of crashing the rebuild TaskGroup.
PR Type
Bug fix
Description
Return false after polling failures
Validate polling responses before indexing
Log tracebacks for diagnostics
Diagram Walkthrough
File Walkthrough
util.py
Harden rebuild polling error handlingecc/app/graphrag/util.py
Falsereturns aftercommunities_have_descquery exceptions.Falsereturns aftervertices_have_embeddingquery exceptions.all_have_descorall_have_embedding.