Repository navigation
Refuse a split index that is not a row number, and an empty assessment set - #157
Merged
Merged
Conversation
…oth in_ids; Known issues and DESIGN updates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry check of the nested drivers and
nested_resamples()now refuse three more shapes of split row index, with classnestedtune_bad_design:in_idorout_idthat is not a numeric vector (character, factor, list, logical),3e9orInf,out_idthat isNULLor empty.The rule extends the existing
NArefusal and runs before the shared-rows and containment rules. One error names every bad split and slot, each by its first shape. The logicalNAout_id, rsample's mark for the complement, stays accepted.Before, these designs passed the check and the fold failed inside rsample or vctrs, or an empty inner assessment set was left out of tuning with no message.
Local:
devtools::test()0 failures,devtools::check()0 errors, 0 warnings, 0 notes.