Skip to content

Refuse a split index that is not a row number, and an empty assessment set - #157

Merged
jmgirard merged 10 commits into
mainfrom
m141-index-shapes
Oct 2, 2026
Merged

jmgirard merged 10 commits into
mainfrom
m141-index-shapes

Conversation

@jmgirard

@jmgirard jmgirard commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

The entry check of the nested drivers and nested_resamples() now refuse three more shapes of split row index, with class nestedtune_bad_design:

  • an in_id or out_id that is not a numeric vector (character, factor, list, logical),
  • a value outside integer range, such as 3e9 or Inf,
  • an out_id that is NULL or empty.

The rule extends the existing NA refusal and runs before the shared-rows and containment rules. One error names every bad split and slot, each by its first shape. The logical NA out_id, rsample's mark for the complement, stays accepted.

Before, these designs passed the check and the fold failed inside rsample or vctrs, or an empty inner assessment set was left out of tuning with no message.

Local: devtools::test() 0 failures, devtools::check() 0 errors, 0 warnings, 0 notes.

@jmgirard
jmgirard merged commit a064698 into main Oct 2, 2026
15 checks passed
@jmgirard
jmgirard deleted the m141-index-shapes branch October 2, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant