topsql_v2: add nextgen coprocessor worker discovery#92
Open
yibin87 wants to merge 2 commits intotidbcloud:0.49from
Open
topsql_v2: add nextgen coprocessor worker discovery#92yibin87 wants to merge 2 commits intotidbcloud:0.49from
yibin87 wants to merge 2 commits intotidbcloud:0.49from
Conversation
|
|
zhoucai-pingcap
requested changes
Apr 24, 2026
| const K8S_INSTANCE_LABEL: &str = "app.kubernetes.io/instance"; | ||
|
|
||
| const TIKV_COMPONENT: &str = "tikv"; | ||
| const COPROCESSOR_WORKER_COMPONENT: &str = "coprocessor-worker"; |
Collaborator
There was a problem hiding this comment.
TIDB worker不用加吗？除了process worker还有一个tikv worker吧？也不用管？
|
|
||
| const TIKV_GRPC_PORT: u16 = 20160; | ||
| const TIKV_STATUS_PORT: u16 = 20180; | ||
| const COPROCESSOR_WORKER_GRPC_PORT: u16 = 9500; |
Collaborator
There was a problem hiding this comment.
为什么要固定呢？有个promethus port的label可以访问吧
|
|
||
| fn build_label_selector(label_k8s_instance: &str) -> String { | ||
| let component_values = std::iter::once(TIKV_COMPONENT) | ||
| .chain(std::iter::once(COPROCESSOR_WORKER_COMPONENT)) |
Collaborator
There was a problem hiding this comment.
最好能增加一个可配置的label，这样以后如果有新形态或者名字变化也不用升级vector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test tikv_nextgen --lib --offlinefailed because the workspace is missing cached dependencyborsh v1.6.0