Skip to content

Sector pages: name Termoenergetica as the source and answer "când se dă drumul la apa caldă" - #43

Merged
tiXor-code merged 1 commit into
mainfrom
sgeo/e4af9060
Oct 16, 2026
Merged

tiXor-code merged 1 commit into
mainfrom
sgeo/e4af9060

Conversation

@tiXor-code

Copy link
Copy Markdown
Owner

termoenergetica avarii sector 2/5/6 slipped from 5-8 to 14-19; cand se da drumul la apa calda sector N sits at 5-9. Combines the two drafts that conflicted on app/sector/[id]/page.tsx.

Prepared by SGEO for Move 33b8333f-face-4df6-8ec1-8aa8390866a3. SGEO merges this after the preview build succeeds.

…dă drumul la apa caldă"

termoenergetica avarii sector 2/5/6 slipped from 5-8 to 14-19; cand se da drumul la apa calda sector N sits at 5-9. Combines the two drafts that conflicted on app/sector/[id]/page.tsx.

SGEO-Proposal: e4af9060-47fc-46df-8a98-8b335179bec0
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
termo-site Ready Ready Preview Oct 16, 2026 6:23pm UTC

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correctness issue in the new restore-term summary; everything else (table header rename, source-attribution paragraph, content JSON bump) looks good and matches the PR description.

restoreSentence silently drops groups with no announced term when summarizing the range (app/sector/[id]/page.tsx:103-116)

const terms = live.groups
  .map((g) => g.remediere_last)
  .filter((t): t is string => t !== null)
  .sort();

remediere_last can be null per-announcement (documented in lib/pt-live.ts:22: "null when the announcement omits it"). A sector can have several concurrent ongoing groups (different cause/start/PTs), so it's realistic for some groups to have a term and others not. In that case terms only reflects the groups that do have a term, and the resulting sentence — "termenul de restabilire anunțat de Termoenergetica era ..." — reads as if it covers every ongoing interruption in the sector, when part of them actually have no announced term at all. This string is both the visible hero/FAQ text and goes into the FAQPage JSON-LD, so the inaccuracy is also what search/AI surfaces.

Suggest adding a branch for the partial case (terms.length > 0 && terms.length < live.groups.length) that says the term is only known for part of the ongoing interruptions, same spirit as the existing "nu precizau un termen" branch for the all-null case.

Minor (non-blocking): worth double-checking that terms.sort() (default lexicographic) always matches chronological order for every remediere_last format actually in the bundle — fine today since values are zero-padded ISO, just flagging the assumption since it's new here.

@claude

claude Bot commented Oct 16, 2026

Copy link
Copy Markdown

@claude please address this review:

  • restoreSentence (app/sector/[id]/page.tsx:103-116) computes the announced restore-term range from live.groups, filtering out groups whose remediere_last is null — but doesn't account for the case where some groups have a term and others don't. The sentence then states a restore time as if it applies to all ongoing interruptions in the sector, which is inaccurate when coverage is partial. Add a branch for terms.length > 0 && terms.length < live.groups.length that says the term is only known for part of the ongoing outages.

@tiXor-code
tiXor-code merged commit 96eb519 into main Oct 16, 2026
3 checks passed
@tiXor-code
tiXor-code deleted the sgeo/e4af9060 branch October 16, 2026 18:23

This branch was successfully deployed

1 active deployment
Preview — 506a37aa Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant