[pull] master from apify:master#215
Merged
Merged
Conversation
…lements` (#3732) `enqueueLinksByClickingElements` installs a context-wide interceptor (`context.route('**', onInterceptedRequest)`); the handler calls `isTopFrameNavigationRequest` -> `req.frame()`, which **throws** when the owning frame is unavailable (request issued by a service worker, or before/after the frame exists). The throw escapes the async `route` handler, so the route is never `continue()`/`abort()`ed: that request hangs and can abort the whole click-and-intercept pass. Reproduces on PWAs and on pages where clicking detaches frames (galleries, paginated forums). ### Fix Wrap the check in `try/catch`; a throw means "not a top-frame navigation", so return `false` and let the request `continue()` normally instead of crashing the route handler. ### Secondary fix (same function) The interceptor is registered with `context.route('**', ...)` but torn down with `context.unroute('*', ...)`. Playwright matches `unroute` by the same URL glob, and `'*' !== '**'`, so the handler is not actually removed - leaking an interceptor across page reuses. Changed to `unroute('**', ...)`. Fixes #3216. Signed-off-by: Gil Cohen <gilc83@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )