SCAL-318580 add insight tile SpotterViz config options and CSS variables#570
SCAL-318580 add insight tile SpotterViz config options and CSS variables#570g-nitin-t wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds new CSS variables for styling insight tiles in Liveboards and introduces new configuration options to SpotterVizConfig. The feedback suggests updating the description of the new background CSS variable to "Background color" to maintain consistency with existing variables in the file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /** | ||
| * Background of the insight tiles in the Liveboard. | ||
| */ |
There was a problem hiding this comment.
To maintain consistency with all other background-related CSS variables in this file (which use "Background color of..."), please update this description to use "Background color" instead of "Background".
| /** | |
| * Background of the insight tiles in the Liveboard. | |
| */ | |
| /** | |
| * Background color of the insight tiles in the Liveboard. | |
| */ |
References
- When adding new code, prioritize maintaining local consistency with existing patterns in the file over introducing a new, more concise pattern if it breaks from the established convention.
commit: |
1 participant
Jira: https://thoughtspot.atlassian.net/browse/SCAL-318580