Skip to content

SCAL-321088 Allow TSE customer to customise the term "Liveboard", "Spotter", "SpotterViz" & "Insight Tile" when agent responds#569

Open
g-nitin-t wants to merge 1 commit into
mainfrom
SCAL-321088
Open

SCAL-321088 Allow TSE customer to customise the term "Liveboard", "Spotter", "SpotterViz" & "Insight Tile" when agent responds#569
g-nitin-t wants to merge 1 commit into
mainfrom
SCAL-321088

Conversation

@g-nitin-t

Copy link
Copy Markdown
Collaborator

Jira: https://thoughtspot.atlassian.net/browse/SCAL-321088

Add liveboardBrandName, spotterBrandName and insightTileBrandName to SpotterVizConfig so embed users can customise the terms "Liveboard", "Spotter" and "Insight tile" in the agent's responses.

@g-nitin-t g-nitin-t requested a review from a team as a code owner July 2, 2026 08:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds three new configuration properties (liveboardBrandName, spotterBrandName, and insightTileBrandName) to SpotterVizConfig to allow customizing terms in the agent's responses, along with corresponding JSDoc documentation and unit tests. The review feedback correctly flags that the JSDoc examples in app.ts, liveboard.ts, and spotter-viz-utils.ts use the deprecated term 'Dashboard' (e.g., liveboardBrandName: 'Dashboard'), which violates Rule 13 of the style guide, and suggests replacing it with 'Liveboard' or 'MyLiveboard'.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/embed/app.ts Outdated
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/spotter-viz-utils.ts Outdated
@pkg-pr-new

pkg-pr-new Bot commented Jul 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@569

commit: d916012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant