SCAL-304326 Add SDK config to set spotter's default query mode#568
SCAL-304326 Add SDK config to set spotter's default query mode#568shikharbsar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the defaultQueryMode configuration option (using the new SpotterQueryMode enum) to allow users to set the default query mode (Fast Search or Research Mode) when loading Spotter in AppEmbed and SpotterEmbed. The parameter is correctly passed to the iframe URL, and comprehensive unit tests have been added to verify this behavior. The review feedback points out that the @version tags in the JSDoc documentation should be updated to use the canonical ThoughtSpot Cloud prefix instead of ThoughtSpot to align with the repository style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| * Only applicable when navigating to Spotter within the app. | ||
| * | ||
| * Supported embed types: `AppEmbed` | ||
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl |
There was a problem hiding this comment.
According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl | |
| * @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl |
|
|
||
| /** | ||
| * The query mode Spotter uses when answering a question. | ||
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl |
There was a problem hiding this comment.
According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl | |
| * @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl |
| * not affect other embeds or native ThoughtSpot usage. | ||
| * | ||
| * Supported embed types: `SpotterEmbed`, `AppEmbed` | ||
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl |
There was a problem hiding this comment.
According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.
| * @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl | |
| * @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl |
commit: |
No description provided.