Skip to content

SCAL-304326 Add SDK config to set spotter's default query mode#568

Open
shikharbsar wants to merge 1 commit into
mainfrom
SCAL-304326
Open

SCAL-304326 Add SDK config to set spotter's default query mode#568
shikharbsar wants to merge 1 commit into
mainfrom
SCAL-304326

Conversation

@shikharbsar

Copy link
Copy Markdown

No description provided.

@shikharbsar shikharbsar requested a review from a team as a code owner July 1, 2026 21:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the defaultQueryMode configuration option (using the new SpotterQueryMode enum) to allow users to set the default query mode (Fast Search or Research Mode) when loading Spotter in AppEmbed and SpotterEmbed. The parameter is correctly passed to the iframe URL, and comprehensive unit tests have been added to verify this behavior. The review feedback points out that the @version tags in the JSDoc documentation should be updated to use the canonical ThoughtSpot Cloud prefix instead of ThoughtSpot to align with the repository style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/embed/app.ts
* Only applicable when navigating to Spotter within the app.
*
* Supported embed types: `AppEmbed`
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.

Suggested change
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl
* @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl
References
  1. The @Version tag must follow the canonical mapping between SDK and ThoughtSpot Cloud versions (e.g., SDK: 1.50.0 | ThoughtSpot Cloud: 26.7.0.cl). (link)

Comment thread src/embed/conversation.ts

/**
* The query mode Spotter uses when answering a question.
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.

Suggested change
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl
* @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl
References
  1. The @Version tag must follow the canonical mapping between SDK and ThoughtSpot Cloud versions (e.g., SDK: 1.50.0 | ThoughtSpot Cloud: 26.7.0.cl). (link)

Comment thread src/embed/conversation.ts
* not affect other embeds or native ThoughtSpot usage.
*
* Supported embed types: `SpotterEmbed`, `AppEmbed`
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, the @version tag must follow the canonical mapping format. For modern versions (26.x.x.cl), the ThoughtSpot version should be prefixed with ThoughtSpot Cloud instead of ThoughtSpot.

Suggested change
* @version SDK: 1.52.0 | ThoughtSpot: 26.9.0.cl
* @version SDK: 1.52.0 | ThoughtSpot Cloud: 26.9.0.cl
References
  1. The @Version tag must follow the canonical mapping between SDK and ThoughtSpot Cloud versions (e.g., SDK: 1.50.0 | ThoughtSpot Cloud: 26.7.0.cl). (link)

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@568

commit: ff9e59a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant