SCAL-321279 Additional flag should be top level override, show analyse and fix it SDK

[shivam-kumar-ts]

WILL MERGE AFTER FEW TESTING

/**
 * Merges the `additionalFlags` provided at init time (via the global
 * embed config) with those provided per-embed (via the view config).
 * View-level flags take precedence over init-level flags.
 * @returns The merged map of additional URL flags.
 */
 
 
 
 
     /**
 * Applies `additionalFlags` on top of the provided query params so that
 * they always override any other flag with the same key. This must be the
 * last mutation applied to the query params, regardless of the embed type,
 * because individual embeds add their own flags after `getBaseQueryParams`
 * runs. Calling this at the final step guarantees `additionalFlags` wins
 * across every embed type.
 * @param queryParams The query params to apply the additional flags on.
 * @returns The same query params object with additional flags applied.
 */

[gemini-code-assist]

Code Review

This pull request refactors the application of additionalFlags across various embed types by introducing a centralized applyAdditionalFlagsOverride helper in TsEmbed. This ensures that additional flags are applied as the final step and correctly override other query parameters. Unit tests have also been added to verify this behavior. The review feedback suggests reassigning the returned value of applyAdditionalFlagsOverride in AppEmbed to ensure future-proof compatibility if the method is refactored to be non-mutating, and adding a defensive check in applyAdditionalFlagsOverride to prevent potential runtime TypeErrors if queryParams is undefined.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@567

commit: 1cf10e6