Repository navigation
Generate a method for each key on first use - #73
Merged
Merged
Conversation
Every `json.key value` went through method_missing, a failed lookup that YJIT cannot cache. method_missing now defines a real method for the key the first time it sees it, following Active Model's attribute methods: generated methods live in their own module, only plain method names are generated, and existing methods are never redefined. Definition happens under a mutex. Defining without one is safe on CRuby: a 16-thread stress test with the race forced only redefined identical methods, printing "method redefined" with warnings on. Without Ractors, only the GVL prevents two definitions at once, on 4.0 as well, so the lock makes that explicit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
json.key valuewent through method_missing, a failed lookup that YJIT cannot cache. method_missing now defines a real method for the key the first time it sees it, following Active Model's attribute methods: generated methods live in their own module, only plain method names are generated, and existing methods are never redefined.