Nested Schema Validation & Type mismatch check#729
Open
AbhinRustagi wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes TH-2076
Add schema-based type/enum validation for component props during materialization. Previously, the materializer only checked for missing required fields and unknown components. Values passed to a component were never validated against the declared JSON Schema type. This fills that gap.
Changes
types.ts: Add ScalarParamType union ("string" | "number" | "boolean") and a schema?: unknown field on ParamDef to carry the raw JSON Schema fragment per parameter. Add "type-mismatch" to ValidationErrorCode.parser.ts: Populateparam.schemafrom the compiled schema duringcompileSchema, so every ParamDef carries its full JSON Schema fragment.materialize.ts:validateSchemaValue— a recursive JSON Schema validator that handles type: object (required keys, declared properties), type: array (single-schema items), and scalar leaf types/enums. Skips composite shapes ($ref, anyOf, oneOf, allOf), runtime AST nodes, and child ElementNodes (those validate as their own elements).describeTypeMismatchandgetScalarTypeInfoas scalar-leaf helpers.validateSchemaValuefor each positional argument after it's materialized, when the param carries a schema.pushValidationErrorhelper to stop repeatingstatementId: ctx.currentStatementIdat every call site.Test Plan
Checklist