topology2: enable WoV function targets and graph - #11114
Open
naveen-manohar wants to merge 3 commits into
Open
Conversation
Include WoV & KPB class, pipeline definitions in cavs-sdw function topology to enable WoV routes, widgets preprocess. Add WoV split-capture function topology targets for RT721, RT722 and WCL DMIC ID5 platforms. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
requested review from
a team,
dbaluta,
jsarha,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
August 22, 2026 04:53
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Wake-on-Voice (WoV) building blocks in the topology2 “cavs-sdw” function topology and adds new Panther Lake (ace3) topology2 production targets that turn on WoV split-capture for specific RT721/RT722/WCL-DMIC configurations. It also introduces a rimage TOML module entry for Google hotword detection and wires it into the WCL rimage config.
Changes:
- Add new topology2 production targets in
tplg-targets-ace3.cmaketo generate WoV-enabled split-capture topologies for RT721, RT722, and WCL DMIC ID5. - Extend
cavs-sdw.confincludes to bring in KPB/WoV classes and WoV/KPB pipeline definitions needed by the new targets. - Add
google_hotword_detect.tomland include it fromwcl.toml.hwhen the component is enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Adds WoV-enabled cavs-sdw topology2 build targets for RT721/RT722/WCL DMIC ID5. |
| tools/topology/topology2/cavs-sdw.conf | Includes KPB/WoV and related pipeline definitions so cavs-sdw function topologies can instantiate WoV graphs. |
| tools/rimage/config/wcl.toml.h | Wires the new Google hotword module TOML into the WCL rimage module list. |
| src/audio/google/google_hotword_detect.toml | Introduces rimage module entry metadata for Google hotword detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+9
| [[module.entry]] | ||
| name = "HOTWORD" | ||
| uuid = UUIDREG_STR_GOOGLE_HOTWORD | ||
| affinity_mask = "0x1" | ||
| instance_count = "1" | ||
| domain_types = "0" | ||
| load_type = "0" | ||
| module_type = "10" | ||
| auto_start = "0" |
Comment on lines
+129
to
+131
| #if defined(CONFIG_COMP_GOOGLE_HOTWORD_DETECT) | ||
| #include <audio/google/google_hotword_detect.toml> | ||
| #endif |
Add Google hotword module manifest for WCL and include it when CONFIG_COMP_GOOGLE_HOTWORD_DETECT is enabled or all modular components are forced. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
Patch moves WoV DMIC-to-KPB route to dmic-wov.conf enabling to use DMIC_WOV_DAI_PIPELINE_SRC instead of the generated dai-copier.DMIC.$index.1 name. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
force-pushed
the
ww346_wov_wcl_sdw
branch
from
August 22, 2026 06:01
886306f to
43d4d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch includes WoV & KPB class, pipeline definitions in cavs-sdw
function topology to enable WoV routes, widgets preprocess.
Add WoV split-capture function topology targets for RT721,
RT722 and WCL DMIC ID5 platforms.
Verified on top of PR:https://github.com/thesofproject/sof/pull/11022/commits