Mt8196/v0.3

[mtkcyril]

No description provided.

[sofci]

Can one of the admins verify this patch?

reply test this please to run this test once

[abonislawski]

test this please

[Copilot]

Pull request overview

This PR introduces a Zephyr “native drivers” path for MediaTek (MT8196) by adding Zephyr-based DMA/DAI drivers for MTK AFE + host memory transfers and wiring them into the MTK Zephyr platform init/build.

Changes:

• Add MTK Zephyr-native DMA drivers (AFE MEMIF DMA + “host DMA” memcpy/cache driver) and a Zephyr DAI wrapper for MTK AFE.
• Switch MTK Zephyr build to select native vs legacy DMA/DAI sources and update platform init to use sof_dma_* in native mode.
• Extend Zephyr-native DAI/device enumeration and allow MTK host DMA for IPC3 host page-table transfers.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
zephyr/lib/dma.c	Adds new DT-based DMA entries for MTK AFE MEMIF and host DMA
zephyr/Kconfig	Adds Kconfig symbol for MTK SOF host DMA driver
zephyr/include/sof/lib/dma.h	Fixes #endif comment for native/legacy include
zephyr/CMakeLists.txt	Selects MTK native vs legacy DMA/DAI source sets
src/platform/mtk/platform.c	Uses sof_dma_get() in native mode; adds SOF-level DMA channel-array allocation
src/platform/mtk/dai.c	Gates legacy DAI/DMA info setup on non-native builds
src/platform/Kconfig	Avoids selecting SCHEDULE_DMA_MULTI_CHANNEL in native mode
src/lib/dai.c	Adds MediaTek AFE devices to Zephyr DAI device list and sets DMA dev mapping
src/ipc/ipc3/host-page-table.c	Allows MTK host DMA driver for page-table transfer in native mode
src/drivers/mediatek/afe/zephyr_mtk_host_dma.c	New MTK “software host DMA” driver (memcpy + cache mgmt)
src/drivers/mediatek/afe/zephyr_mtk_dai.c	New Zephyr DAI driver for MTK AFE that bridges to SOF AFE functions
src/drivers/mediatek/afe/zephyr_mtk_afe_memif.c	New Zephyr DMA driver for MTK AFE MEMIF
src/audio/dai-zephyr.c	Adds MediaTek AFE case to Zephyr DAI config translation
app/boards/mt8196_mt8196_adsp.conf	Enables Zephyr native drivers + DMA/DAI for MT8196 board config

Comments suppressed due to low confidence (2)

src/drivers/mediatek/afe/zephyr_mtk_host_dma.c:163

• mtk_host_dma_get_status() always returns success without populating struct dma_status. SOF's host Zephyr component relies on dma_get_status() fields like free, pending_length, read_position, and write_position to decide how many bytes to copy. Returning 0 with uninitialized status data can cause incorrect copy sizes or undefined behavior. Please either properly fill stat (and track positions/busy state) or return a clear error (e.g. -ENOTSUP) until implemented.

static int mtk_host_dma_get_status(const struct device *dev,
				   uint32_t chan_id, struct dma_status *stat)
{
	return 0;
}

src/drivers/mediatek/afe/zephyr_mtk_host_dma.c:111

• mtk_host_dma_config() dereferences config->head_block before validating it is non-NULL (e.g. config->head_block->source_address). If a caller passes block_count == 1 with head_block == NULL, this will crash. Please check config and config->head_block for NULL before any dereference, and validate block_size/addresses afterward.

	if (config->block_count != 1) {
		LOG_ERR("invalid number of blocks: %d", config->block_count);
		return -EINVAL;
	}

	if (!config->head_block->source_address) {
		LOG_ERR("got NULL source address");
		return -EINVAL;
	}

	if (!config->head_block->dest_address) {
		LOG_ERR("got NULL destination address");
		return -EINVAL;
	}