Repository navigation
feat(catalog): add publication columns (doi, pmid, publication_year, publication_verify_status) - #17
Merged
Merged
Conversation
…publication_verify_status) The engine's publication-verification backfill writes doi/pmid/publication_year/ publication_verify_status onto every artifact, but inventory_to_catalog conforms the catalog to CATALOG_COLUMNS, which lacked these four — so they were silently dropped from catalog.parquet and never reached the website. Add them as optional (non-required) string columns. Website build (verify badge, completeness, /stats panel) reads them from the catalog.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 19 19
Lines 1460 1460
=======================================
Hits 1342 1342
Misses 118 118 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
doi,pmid,publication_year,publication_verify_status(all optionalstring) to_catalog_schema.CATALOG_COLUMNS.Why (blocker found during the publication-metadata rollout)
The engine backfilled these four fields onto all 1690 live artifacts, and
inventory_to_catalogbuilds them — but it conforms the DataFrame toCATALOG_COLUMNS, which didn't include them, so they were silently dropped fromcatalog.parquet. The published catalog therefore had no publication data and the website couldn't render the verify badge / completeness //statsverification panel (which already expectdoi/publication_verify_status).Non-required, so datasets without a publication stay valid (typed nulls).
Test
tests/test_catalog_schema.py,tests/test_catalog.py: 64 passed. No column-count assertion to update (only subset invariants).After merge
Reinstall
sddbin the engine publish env on the HPC and re-runsddb publish-catalog --instance scverse/spatialdata-db --yes— the four columns will then populate (1213 with DOI, 1044 verified).