fix(site): list works instead of references on CitationSystem pages (#55) - #56
Merged
Merged
Conversation
…extrefs#55) CitationSystem pages listed every canonical reference expressed in the system — 27k for homer-book-line — which is both an information-model mismatch (a system is associated with works; references are individual locations) and the reason those pages ran long. The section is now "Works using this system": each associated work once, linked to its Work page, with the number of references it contributes and an empty state when a system has no works. Individual references stay reachable from Work pages (/reg/work/<key>/refs/) and /id/ref/<uuid>/. The paginated /reg/system/<key>/refs/<page>/ route is removed with it — the preview section was its only inbound link, so it would otherwise build orphan pages. Fixes textrefs#55 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55. Targets
staging, so it ships with the v0.1.0 release PR #4.Problem
/id/system/<key>/listed every canonical reference expressed in the system — 27,803 of them forhomer-book-line, 5,220 forbekker. That is an information-model mismatch: a citation system is associated with works; references are individual locations expressed using the system. It also made the pages long and buried the relationship that actually matters.Change
The section is now "Works using this system (N)": each associated work exactly once, linked to its Work page, with its
keyand the number of references it contributes. Systems with no works get the standardreg-emptymessage.The list mirrors the inverse section that already exists on Work pages ("Citation systems",
src/pages/id/work/[key]/index.astro) and reuses the samereg-list/reg-iri/reg-tagclasses, so both directions of the relation now read the same way.Real data after the change — multi-work systems list all of their works:
homer-book-linebible-book-chapter-versebekker/reg/system/<key>/refs/<page>/is removed along with the preview: that section was its only inbound link, so keeping the route would have built orphan pages. Individual references remain reachable from Work pages (/reg/work/<key>/refs/<page>/) and/id/ref/<uuid>/, and/id/system/<key>.jsonis unchanged.Since the section is no longer a wall of locators, it drops
data-pagefind-ignoreand is indexed like the equivalent section on Work pages.Verification
npm run format:check,npm run check:fast(0 errors),npm run build:fast, and a fullnpm run buildagainst the real registry submodule — Astro's internal link check passes andgrep -r "reg/system" distis empty.Fixture Work fixture.work 1 reference(s)— the explicit{' '}separators from docs: Missing whitespace around inline elements on registry pages #53 are preserved, so copy/paste, assistive technology and the Pagefind index still see word boundaries.🤖 Generated with Claude Code