fix(data): coerce whole-number judge score and threshold to number - #14
Merged
Merged
Conversation
DuckDB infers BIGINT for whole-number JSON values such as a perfect judge score of 1, so queryTestRunDetails returned a BigInt that c.json() could not serialize, causing a 500 on the test run detail page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a test run detail page returned a 500 (
SyntaxError: Unexpected token 'I', "Internal S"... is not valid JSONin the browser).When every judge score in a batch is a whole number (for example, a perfect score of
1), the JSONL value is written without a decimal point. DuckDB then infersjudge_scoreas BIGINT when it builds the parquet file.queryTestRunDetailsreturned a JSBigInt, and Hono'sc.json()threw because JSON cannot serialize BigInts.Fix
scoreandthresholdwithNumber(...)when buildingllmJudgeGroups. This is done in JS rather than SQL because the query usesSELECT *, and older parquet files may not have the judge columns.Number(...)wrapper in an existing test that hid the bug.Verification
make test: 1032 passed.