fix(data): create the analytics data directory before writing parquet - #13
Merged
Merged
Conversation
updateAllParquet wrote parquet files with DuckDB COPY ... TO, which does not create parent directories. On a project with no analytics/ directory yet, update-analytics-data failed with an IO Error on test-config.parquet. The integration tests all pre-created dataDir, which hid the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
skillwalker update-analytics-datain a project that has noanalytics/directory yet fails:This happens the first time you run it after a test run and evals.
updateAllParquetwrites each table with DuckDB'sCOPY ... TO, and DuckDB does not create missing parent directories. No production code created the data dir. Every integration test createddataDirwithmkdirbefore callingupdateAllParquet, so the tests never caught it.Fix
updateAllParquetnow callsmkdir(dataDir, { recursive: true })before it imports anything (packages/data/src/analytics.ts).updateAllParquetwith a data dir that doesn't exist. Before the fix it failed with the same IO error.docs/data.mdto sayupdateAllParquetcreates the data directory.Verification
make test: all 1031 tests pass.