Skip to content

Optimize config merging in get_config method #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaddipatlaChetan24 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize config merging in get_config method #1554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tensorflow_text/python/keras/layers/todense.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,8 @@ def get_config(self):
'shape': self._shape,
}
base_config = super(ToDense, self).get_config()
return dict(list(base_config.items()) + list(config.items()))
# Plain dict-merge instead of building two intermediate lists via
# list(...) + list(...) just to re-wrap them with dict(); same result
# (config's keys still take precedence on any overlap), no throwaway
# list allocations.
return {**base_config, **config}