Repository navigation
Fix header backgrounds in light and dark themes - #7165
Merged
cdavalos7 merged 2 commits intoOct 20, 2026
Merged
Conversation
… 21's M2 toolbar ignores TensorBoard's `app-bar` color
cdavalos7
marked this pull request as ready for review
October 15, 2026 01:04
arcra
approved these changes
Oct 15, 2026
Member
There was a problem hiding this comment.
Is this import still necessary? I think maybe we can remove this (and potentially a dependency in the BUILD file too)
Contributor
Author
There was a problem hiding this comment.
Thank you good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This fixes a regression from the Angular 21 upgrade. Material 21's M2 toolbar stopped reading TensorBoard's
app-barcolor, so the header turned white with white text in the light theme, and parts of it stayed orange in the dark theme.Technical description of changes
header_component.scssoverrides the toolbar tokens with$tb-app-bar-colorin the light theme and the dark palette'scardcolor in the dark theme.plugin_selector_component.scssmakes it transparent.--mat-toolbar-container-background-color.tensorboard-color.tsdefines--tb-toolbar-background-colorfor the dark theme.Screenshots of UI changes (or N/A)
Errors fixed: