pypi description load from README#1057
Open
kenya-sk wants to merge 4 commits intotensorflow:masterfrom
Open
Conversation
kenya-sk
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates image URLs in README.md to absolute paths and modifies release/setup.py to dynamically load the long description from the README file. Feedback suggests refactoring setup.py to eliminate duplicated path resolution logic and recommends dynamically transforming relative image paths during the build process to maintain repository portability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the project
README.mdas the PyPI long description instead of the hardcoded module docstring inrelease/setup.py(Issue #1055 ).Keep image paths in
README.mdrelative for repository portability, and rewrite them to absolute GitHub raw URLs only when generating the PyPI long description so they continue to render correctly on PyPI.