add: unit test for random circuit generation#1056
Open
kenya-sk wants to merge 5 commits intotensorflow:masterfrom
Open
add: unit test for random circuit generation#1056kenya-sk wants to merge 5 commits intotensorflow:masterfrom
kenya-sk wants to merge 5 commits intotensorflow:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces unit tests for random_circuit_resolver_batch and random_symbol_circuit_resolver_batch to verify their output types and shapes. The review feedback suggests expanding the test coverage to include cases where include_channels=True, as well as adding more rigorous assertions to ensure circuits are correctly parameterized or non-parameterized as expected.
| len(serializer.SERIALIZER.supported_gate_types()) - | ||
| len(util.get_supported_gates())) | ||
|
|
||
| def test_random_circuit_resolver_batch_shapes_and_types(self): |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have addressed Issue #1037.
This test case check the output shape and type from
random_circuit_resolver_batchandrandom_symbol_circuit_resolver_batch.The following are the results of test cases.