Skip to content

Fix heartbeat task-slot/poller info reporting 0 with MetricBuffer - #1820

Open
Mahnoor-Zaffar wants to merge 1 commit into
temporalio:mainfrom
Mahnoor-Zaffar:bmcqueen/heartbeat-metricbuffer-labels
Open

Fix heartbeat task-slot/poller info reporting 0 with MetricBuffer#1820
Mahnoor-Zaffar wants to merge 1 commit into
temporalio:mainfrom
Mahnoor-Zaffar:bmcqueen/heartbeat-metricbuffer-labels

Conversation

@Mahnoor-Zaffar

Copy link
Copy Markdown

What & Why

Fixes #1817. When a worker uses TelemetryConfig(metrics=MetricBuffer(...)), every labelled worker-heartbeat metric (task-slot and poller counts) was reported to the server as 0, hiding them from the Workers UI.

The bug is in Core: heartbeat slot/poller gauges are written via an in-memory tap that resolves labels from metric attributes, but the buffered attributes handle couldn't be read core-side. This PR bumps the sdk-core submodule to a commit that retains the key-value pairs core-side so label resolution works without touching the lang-held buffer.

The actual Core fix lives in temporalio/sdk-rust#1593.

Changes

  • Bump temporalio/bridge/sdk-core submodule to 7d95a31e (buffered heartbeat metric label fix).
  • CHANGELOG entry under [Unreleased].

Validation

@Mahnoor-Zaffar
Mahnoor-Zaffar requested a review from a team as a code owner September 5, 2026 13:43
@CLAassistant

CLAassistant commented Sep 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Heartbeat Task Slot information is not pulled when MetricBuffer is configured

2 participants