馃挜 Fix wrong exception thrown by manual activity heartbeats - #3057
Open
dplyukhin wants to merge 3 commits into
Open
馃挜 Fix wrong exception thrown by manual activity heartbeats#3057dplyukhin wants to merge 3 commits into
dplyukhin wants to merge 3 commits into
Conversation
Contributor
Author
|
@Quinn-With-Two-Ns this is a reopened version of #2990 with your review comments incorporated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
馃挜 BREAKING CHANGE:
ManualActivityCompletionClientImpl.recordHeartbeatcan now throwActivityCanceledException/ActivityResetException/ActivityPausedException. Previously, those exceptions were wrapped insideActivityCompletionFailureExceptionand you had to access them withgetCause().Other changes:
ActivityHeartbeatResponse: New wrapper class to reduce code duplicationManualActivityCompletionClientImplTestunit testWhy?
ActivityCompletionFailureExceptionis supposed to be mutually exclusive withActivityCanceledException/ActivityResetException/ActivityPausedException; it shouldn't wrap them.Checklist
Closes Manual completion client's recordHeartbeat swallows cancellation, reset and pause exceptions聽#2983
How was this tested: Added
ManualActivityCompletionClientImplTestunit test to check that thrown exceptions have the expected type.