Fix TypeScript protobuf resolution - #474
Closed
stephanos wants to merge 2 commits into
Closed
Conversation
stephanos
commented
Sep 7, 2026
| }, | ||
| MoreDependencies: map[string]string{ | ||
| "@grpc/proto-loader": "^0.8.0", | ||
| "protobufjs": "^8.7.1", |
Collaborator
Author
There was a problem hiding this comment.
Fails without this.
Collaborator
Author
|
Closed in favor of #475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/temporalio/featuresto the commit from Bump protobufjs pnpm override 7.5.1 → ^8.7.1 features#892protobufjsas a direct dependency of generated TypeScript workersWhy
The TypeScript kitchen-sink job began resolving SDK 1.23.0, whose protobuf JSON converter requires protobufjs 8. The old features override forced protobufjs 7.5.1, causing
Cannot find module 'protobufjs/ext/protojson'. After lifting that override, OMES generated code still resolved protobufjs from the parent source package while the SDK converter resolved it from the generated pnpm package; the two module instances have distinctTypeclasses and failed withtype must be a Type.Declaring protobufjs in the generated package keeps both sides on the same pnpm module instance. Aligning OMES's configured TypeScript worker baseline with 1.23.0 avoids exercising that protobufjs 8 package with the incompatible 1.22 SDK, and committing the synchronized worker manifests keeps the dependency freshness check clean.
Merge order
Testing
SDK=typescript go test -v -race ./loadgen -run TestKitchenSink -count=1go test -race ./internal/workerctlnpm --prefix workers/typescript run typechecknpm --prefix workers/typescript run lint-cimise run sync-sdk(verified idempotent)git diff --check