Skip to content

fix(ci): Vale flagging MDX custom heading-ID comments as prose#4833

Merged
lennessyy merged 2 commits into
mainfrom
vale-fix-mdx-heading-id
Jul 7, 2026
Merged

fix(ci): Vale flagging MDX custom heading-ID comments as prose#4833
lennessyy merged 2 commits into
mainfrom
vale-fix-mdx-heading-id

Conversation

@lennessyy

@lennessyy lennessyy commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Headings using MDX's custom heading-ID syntax, e.g. ## Highly available Worker patterns {/* #ha-worker-patterns */}, were being scanned as prose by Vale
  • Kebab-case anchor slugs (like ha-worker-patterns) trip Temporal.terms whenever they happen to contain a lowercase Temporal term substring (e.g. "worker")
  • This pattern is used in 315 files across the docs
  • Adds a TokenIgnores rule to .vale-ci.ini excluding MDX comment syntax ({/* ... */}) from both Temporal.terms and Temporal.Headings

Test plan

  • Verified the reported case (## Highly available Worker patterns {/* #ha-worker-patterns */}) no longer flags
  • Verified a genuinely bad heading (lowercase "worker" in the visible heading text) still gets flagged
  • Ran the full vale/test/ regression suite — no change in existing findings
  • Spot-checked a real docs file using this pattern (docs/encyclopedia/temporal.mdx)

┆Attachments: EDU-6663 Fix Vale flagging MDX custom heading-ID comments as prose

Headings like '## Highly available Worker patterns {/* #ha-worker-patterns */}'
were being scanned as prose, so kebab-case anchor slugs (e.g.
'ha-worker-patterns') tripped Temporal.terms whenever they happened to
contain a lowercase Temporal term substring. This pattern is used in
315 files. Add a TokenIgnores rule to exclude MDX comment syntax
({/* ... */}) from both Temporal rules.
@lennessyy lennessyy requested a review from a team as a code owner July 6, 2026 21:13
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview, Comment Jul 7, 2026 10:37pm

Request Review

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

This PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here.

@lennessyy lennessyy changed the title Fix Vale flagging MDX custom heading-ID comments as prose fix/ci: Vale flagging MDX custom heading-ID comments as prose Jul 7, 2026
@lennessyy lennessyy changed the title fix/ci: Vale flagging MDX custom heading-ID comments as prose fix(ci): Vale flagging MDX custom heading-ID comments as prose Jul 7, 2026
@lennessyy lennessyy merged commit bc7a18d into main Jul 7, 2026
11 checks passed
@lennessyy lennessyy deleted the vale-fix-mdx-heading-id branch July 7, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants