feat(activity): add activity reset --clear-heartbeat-details - #1199
Open
ks-temporal wants to merge 2 commits into
Open
feat(activity): add activity reset --clear-heartbeat-details#1199ks-temporal wants to merge 2 commits into
activity reset --clear-heartbeat-details#1199ks-temporal wants to merge 2 commits into
Conversation
Resurrects the `--reset-heartbeats` flag removed from `activity reset` in PR #1092, as a new flag `--clear-heartbeat-details`. It controls the existing `reset_heartbeat` field on both the single-activity request and the batch operation, and the proto field is unchanged as `ResetHeartbeat`. resets via `--query` always cleared heartbeat details, while the single-activity did not, as the default is to not clear the details. Both paths are now controlled by this flag. Rename `#reset-heartbeats` anchor to `#clear-heartbeat-details` for consistency. Tests cover the flag on both single activity and batch paths.
ks-temporal
marked this pull request as ready for review
September 10, 2026 06:19
ks-temporal
requested review from
fretz12
and
a balanced review from Copilot
September 10, 2026 06:20
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The breaking batch-default change is not marked with 💥 in the PR title as required.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds activity reset --clear-heartbeat-details, consistently controlling heartbeat clearing for single and batch resets.
Changes:
- Adds and documents the new flag.
- Maps it to
ResetHeartbeatfor both reset paths. - Adds request-level and functional tests.
File summaries
| File | Description |
|---|---|
internal/temporalcli/commands.yaml |
Defines flag and help text. |
internal/temporalcli/commands.gen.go |
Updates generated command wiring. |
internal/temporalcli/commands.activity.go |
Applies flag to reset requests. |
internal/temporalcli/commands.activity_test.go |
Tests defaults, mapping, and behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Resurrects the
--reset-heartbeatsflag removed fromactivity resetin PR #1092, as a new flag
--clear-heartbeat-details. It controls theexisting
reset_heartbeatfield on both the single-activity request andthe batch operation, and the proto field is unchanged as
ResetHeartbeat.💥 #1092 also hardcoded
reset_heartbeat: trueon the batch path,so batch resets via
--queryalways cleared the heartbeat details, while thesingle-activity did not, as the default is to not clear the details. This change
in behavior was triggered in that PR, and now this new PR reverts the
default behavior to what was before that PR.
Both paths are now controlled by this flag.
Rename
#reset-heartbeatsanchor to#clear-heartbeat-detailsfor consistency.
Tests cover the flag on both single activity and batch paths.
Checklist
Stability
Design
--search-attribute, bad:--index-field)Help text (see style guide at the top of
commands.yaml)Tests
SharedServerSuite)