Fix rootless gateway control socket - #259
Open
tella-butler wants to merge 1 commit into
Open
Conversation
🤖 OS review · approve · confidence 5/5Safe to merge. The change correctly resolves the control socket beneath
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XDG_RUNTIME_DIRfor rootless systemd user services/run/opensession-gatewaypath for system services and preserve explicit overridesRoot cause
The rootless unit creates
RuntimeDirectory=opensession-gatewayunder/run/user/<uid>, but the source gateway supervisor always listened on/run/opensession-gateway/control.sock. On a clean Ubuntu install that parent directory does not exist, so the supervisor crash-loops withENOENTwhile ingress remains up with no backend.This is deterministic on current
origin/main, not a readiness flake. A fresh Ubuntu 24.04 systemd container reproduced the installer exit after both readiness windows. With this change, the same clean install exits 0,/api/healthresponds, all three user services are active, and the control socket is owned by the installing user under/run/user/<uid>/opensession-gateway.Verification
bun test scripts/lib/service.test.ts packages/core/opensession-server/src/server/gateway-supervisor.test.tsbun scripts/check-module-side-effects.tsbun run checkinstall.sh --yes --no-enginebefore and after the fixStarted by Johnny Lin in this OS session