Repository navigation
ci: index docker-images by pull request number - #766
Conversation
ahal
changed the title
e5b343f to
8728ebb
Compare
|
Example of how I'm using this: (I guess we don't even need to land this PR for my testing purposes, but might as well) |
4c73607 to
20c2b32
Compare
7364316 to
9b4feb1
Compare
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Not sure I'm sold on this being something we need/want more generally.. so -0 from me.
|
Fair enough, I don't really care too much. Though keep in mind that in the future Gecko will be using the decision image rather than the gecko_decision image, so testing changes to the decision image cross repo will become more common. |
4f23f88 to
ac2a53c
Compare
|
I think I would like to get this landed as I keep alternating between rebasing onto this stack to test, and then rebasing off of it to get review. I've accidentally forgotten to rebase onto it a few times, resulting in me wasting time due to the wrong image getting used >< |
fe9f34e to
e9fa779
Compare
|
Latest version of the patch makes this only apply to Taskgraph CI rather than everywhere. |
e9fa779 to
bc05f73
Compare
This will allow us to index tasks by pull request which can help testing changes in external repos.
bc05f73 to
b2831c2
Compare
| } | ||
|
|
||
| for task in tasks: | ||
| subs["task-name"] = task.get("name") or task["label"][len(config.kind) + 1 :] |
There was a problem hiding this comment.
is the label guaranteed to start with the kind's name?
There was a problem hiding this comment.
Nope, but it is for docker-image tasks :p.. Since the transform is self_taskgraph specific, I don't really care about making it solve all possible cases (if we were adding this in the core module, then we'd have to be smarter about it).
2 participants
This will make it easier to test out images (e.g, the Decision image) in other repos before we merge them in Taskgraph.