Skip to content

fix(cached_tasks): add worker-type to digest - #1079

Open
ahal wants to merge 1 commit into
taskcluster:mainfrom
ahal:ahal/spnqosnpnurt
Open

ahal wants to merge 1 commit into
taskcluster:mainfrom
ahal:ahal/spnqosnpnurt

Conversation

@ahal

@ahal ahal commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

When a task runs on a different worker-type, the underlying environment could be completely different. Or not.

It could be a simple instance type change that has no impact on the task's artifact, or it could be a different OS, a different cloud provider or even a different worker binary.

Therefore it's best to include the worker-type in the cached task digest.

When a task runs on a different worker-type, the underlying environment
could be completely different. Or not.

It could be a simple instance type change that has no impact on the
task's artifact, or it could be a different OS, a different cloud
provider or even a different worker binary.

Therefore it's best to include the worker-type in the cached task
digest.
@ahal ahal self-assigned this Oct 19, 2026
@ahal
ahal requested a review from a team as a code owner October 19, 2026 15:46
@ahal
ahal requested a review from hneiva October 19, 2026 15:46
@ahal

ahal commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

For context, this was made to prevent bustage like:
https://firefox-ci-tc.services.mozilla.com/tasks/HeZb5o0wREy7y_vp8jm-Fw/runs/0/logs/public/logs/live_backing.log

Which happened because:
mozilla/glean@abb64dd

Switched the images pool to g-w, but didn't invalidate existing cached tasks. Then the task expired almost a year later and the issue surfaced.

@bhearsum bhearsum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings on this. There are many changes to worker-type that do not affect the cache digest (ie: changing from a small to a large instance). There can also be changes to worker images that do not change the worker type that do affect the cache digest.

On balance, I think this is safe the option, but it's unclear how much it's going to cost in cached task rebuilding, and how much more often it will cause us to do so at inconvenient times (eg: when uplifting patches around an urgent release).

Because this is easy to revert if we change our mind, I'm approving, but I wanted to voice those potential concerns.

@ahal

ahal commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

There's no rush to land this, we can debate a bit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants