Repository navigation
perf(decision): stop re-parsing the full task graph - #1055
Merged
Merged
Conversation
The decision task rebuilt Task objects for the whole full task graph from its JSON representation, only to check that TaskGraph.from_json works. This is already covered by the TaskGraph tests, and costs time proportional to the size of the full task graph on every decision task.
bhearsum
approved these changes
Oct 5, 2026
bhearsum
left a comment
bhearsum
left a comment
Contributor
There was a problem hiding this comment.
tracing this back to mozilla-firefox/firefox@c9a71b5 seems to confirm that comment. It would be worth removing from gecko too if you don't mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decision task rebuilt Task objects for the whole full task graph from its JSON representation, only to check that TaskGraph.from_json works. This is already covered by the TaskGraph tests, and costs time proportional to the size of the full task graph on every decision task.