Repository navigation
perf(time): cache parsed relative time strings - #1052
Merged
Merged
Conversation
`value_of` parsed the same few relative time strings ("1 day",
"28 days", ...) with a regex every time, although task definitions
contain several of them and are resolved multiple times. Its results
are timedeltas, which are immutable, so they are now cached.
On a typical task definition, resolve_timestamps takes 16.4us instead of
20.5us.
bhearsum
approved these changes
Oct 4, 2026
bhearsum
reviewed
Oct 4, 2026
bhearsum
left a comment
bhearsum
left a comment
Contributor
There was a problem hiding this comment.
This makes me wonder if we should have some static built-ins (and a way to add to them maybe?). It seems a little silly to be calculating some of these even once.
In any case, this is a useful improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
value_ofparsed the same few relative time strings ("1 day", "28 days", ...) with a regex every time, although task definitions contain several of them and are resolved multiple times. Its results are timedeltas, which are immutable, so they are now cached.On a typical task definition, resolve_timestamps takes 16.4us instead of 20.5us.