Conversation
bradfitz
reviewed
Sep 22, 2026
| - run: go test -count=1 -timeout 600s ./... | ||
| - run: go vet ./... | ||
| - name: build libtailcat and run its C smoke test | ||
| if: runner.os != 'Windows' |
Member
There was a problem hiding this comment.
no Windows support, eh? That was the other thing tempering my enthusiasm for the other PRs.
Author
There was a problem hiding this comment.
Hm I'm actually not 100% sure why we ended up with no windows support -- I think it's mostly a toolchain issue and so should be fixable. Luckily I have lots of windows knowledge, so I can add this.
Author
There was a problem hiding this comment.
Added a commit for windows -- it was already working, just added CI build steps and instructions.
6639835
approved these changes
Sep 23, 2026
libtailcat already builds as a DLL with MinGW-w64 gcc, Go's default CC on Windows, but CI skipped the C smoke test there and nothing documented how MSVC users, who cannot build the DLL themselves, link against it. Run the smoke test step on all three runners under bash, picking the library suffix from the runner OS and building into a relative build/ directory so Git Bash needs no path conversion and Windows finds the DLL next to smoke.exe. Add a Windows-only step that builds an import library from a checked-in libtailcat.def with lib /def:, compiles the smoke test with cl /W4 /WX, and runs it against the MinGW-built DLL. A test in internal/capi keeps libtailcat.def, the prototypes in tailcat.h, and the //export directives in main.go in agreement. Document the Windows toolchain requirements and the import library step in the libtailcat README. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, another C API; I became aware of #64 and #6 but I think there are two improvements here that aren't in either of those:
I'm using this to implement a python wrapper for tailcat, as well as a httpx/httpcore transport (which I'm happy to put in here, but I think it's probably better served as a separate repo/library, like other language wrappers?)
Written mostly by Astra and a bit with Fable, reviewed by me.