Repository navigation
Traefik, Docmost, Coder, Kaneo, Miniflux, Tandoor, Pocket ID: close exposed services - #374
Open
jackspiering wants to merge 1 commit into
Open
jackspiering wants to merge 1 commit into
jackspiering wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes network exposure in seven stacks.
--api.insecure=truebecomes--api.dashboard=true, and--ping=truestays for the health check.mydashboardrouter is removed. Before this change, any LAN host sendingHost: traefik.domain.localto port 80 got the dashboard and API.listen_addresses=localhost. The READMEs no longer say the database listens on the Tailscale IP, and each has an "Upgrading" note.ENCRYPTION_KEYis now required incompose.yaml. It reached the app only throughenv_file, so Compose passed with it empty and the app crash-looped.Related Issues
Verification
Each stack was run from a scratch copy in
/tmp, once on the original files and once on the new ones, one stack at a time. The Tailscale service was a busybox stub, so no Tailnet node was created./pinganswers. The dashboard and API return 404 on ports 80 and 8080. Before, port 80 returned 200 without credentials. The documented basic-auth recipe returns 401 without credentials and 200 with them.0.0.0.0and accepted connections at the namespace address. After, they listen only on127.0.0.1and::1, and the namespace address refuses connections. Each one initialised a fresh data directory.healthy.ENCRYPTION_KEYcrash-loops withENCRYPTION_KEY must be at least 16 bytes long.docker compose config --quietpasses in all seven directories with dummy values.rumdl check --config .markdownlint.yml .(0.2.78) andgit diff --check origin/mainare clean. Images and volumes were removed after each stack.Not tested: upgrading over an existing data directory (only a
command:line changed), LAN access through the published port 80, Pocket ID'sENCRYPTION_KEY_FILE, and a bcrypt hash in the dashboard recipe (anopenssl passwd -apr1hash was used).Checklist
Additional Context
From an external review of the repository (section 3.1). I removed the Traefik dashboard router instead of requiring a new
TRAEFIK_DASHBOARD_USERS, because a required variable would stopdocker compose upfor every existing user.