Repository navigation
fix(inputs): ignore IME confirmation Enter in filter editors - #627
Merged
Merged
Conversation
Contributor
Code Metrics Report
Details | | main (7f27830) | #627 (4c5b5d7) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 89.2% | 89.3% | +0.0% |
| Files | 226 | 227 | +1 |
| Lines | 7239 | 7240 | +1 |
+ | Covered | 6464 | 6469 | +5 |
- | Test Execution Time | 2m39s | 2m44s | +5s |Code coverage of files in pull request scope (88.8% → 89.2%, patch 100.0%)
Reported by octocov |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow changes preserve existing interaction contracts, include targeted regression coverage, and have no unresolved findings.
No open issues 🎉
What changed in this PR
Prevents IME confirmation Enter from prematurely committing DataTable filters, while aligning composition handling across AppShell inputs.
Changes:
- Adds shared IME detection with the
keyCode: 229fallback. - Preserves normal Enter commits and existing cell-editor safeguards.
- Adds regression coverage and a patch changeset.
| File | Description |
|---|---|
| packages/core/src/lib/is-composing.ts | Adds shared IME detection. |
| packages/core/src/lib/is-composing.test.ts | Tests composition signals and defaults. |
| packages/core/src/components/data-table/toolbar.tsx | Guards eight filter commit handlers. |
| packages/core/src/components/data-table/toolbar.test.tsx | Tests IME handling in panel and chip editors. |
| packages/core/src/components/data-table/editable-cell.tsx | Reuses detection while preserving existing safeguards. |
| packages/core/src/components/command-palette/command-palette.tsx | Adds fallback detection to keyboard handling. |
| packages/core/src/components/command-palette/command-palette.test.tsx | Tests IME suppression and normal Enter. |
| packages/core/src/components/ai-chat/composer.tsx | Guards submission with shared detection. |
| packages/core/src/components/ai-chat/ai-chat.test.tsx | Tests IME suppression and subsequent submission. |
| .changeset/quiet-inputs-compose.md | Records the patch release changes. |
Review effort: Balanced
interacsean
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DataTable filter inputs treat every Enter keydown as a request to apply the filter, including the Enter used to confirm an IME conversion. When composing a value in multiple parts, the chip editor closes after the first confirmation, preventing further input. The add-filter panel stays open but applies intermediate values and can trigger unnecessary searches.
The command palette and AI chat already ignore
isComposingevents, but do not handle browsers that dispatchcompositionendbefore the confirmation keydown. Such events can haveisComposing: falsewhile retainingkeyCode: 229.Fixes https://github.com/tailor-inc/platform-planning/issues/2138
Design Decision
Shared internal IME detection
Use one internal predicate for native
isComposing, thekeyCode: 229fallback, and existing locally tracked composition state. Apply it to all eight filter commit handlers and reuse it in the command palette, AI chat, and cell editors to keep the behavior consistent.Preserve existing interaction contracts
Keep ordinary Enter commits, explicit Apply actions, validation, and event propagation behavior unchanged. Cell editors retain their composition refs and Base UI handler suppression. No public API or dependency is added.
Summary