Add resource-catalog-based workbook templating and authoring CLI - #4
Open
jarhun88 wants to merge 2 commits into
Open
Add resource-catalog-based workbook templating and authoring CLI#4jarhun88 wants to merge 2 commits into
jarhun88 wants to merge 2 commits into
Conversation
Resolves conflicts by keeping both workbook-authoring approaches as separate skills: tableau-workbook-templating (catalog/CLI-driven, from this branch) and tableau-workbook-authoring (hand-edit-XML, from main), with tableau-workbook-authoring preferred as the fallback when the catalog doesn't cover a request. Updates all cross-references (pulse insights, validate-workbook-package, content-viewer, analytics, shared rendering doc, both READMEs) and renames the CLI test file's skill references accordingly. Also fixes plugins/tableau/.mcp.json, which auto-merged to a broken state combining main's http:// (not https://) URL regression with an unrelated uncommitted tableau-test-dataplane3 scratch entry that was sitting in the working tree — restored to the documented https://mcp.tableau.com/tableau-mcp with no extra entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/tableau/resources/— a generated catalog (catalog.json) of Tableau bookmark chart templates, worked examples, and reference docs, each classifiedexecutable(renderable) orreference(inspiration only)plugins/tableau/scripts/tableau_resources.py— a CLI (list/inspect/instantiate/inject/validate) that discovers, inspects, and safely transforms.twbworkbooks against the catalog via text-splice XML edits, self-verified with an expat/ElementTree reparse-and-compare on every editplugins/tableau/scripts/generate_resource_catalog.pyto build the catalog deterministically from the bundled resourcestableau-pulse-insightsskill scoped to thepulse-insightstemplate familyunittestsuite (216 tests) covering datatype-family rejection, delta-vs-absolute validation, fail-closed paths, and byte-for-byte preservationNote for reviewers
This branch (
twb-templates) diverged frommainbeforemain's XSD schemas,tableau-analytics/tableau-content-viewerskills, andrender_embed.pywork landed, so this PR has merge conflicts in.agents/plugins/marketplace.json,.gitignore, and rootREADME.mdthat need manual resolution before merge. It does not touchmain's schemas/render_embed/reload-plugin work directly, but the two branches represent different designs for workbook authoring (main: download → edit TWB XML by hand → upload/publish; this branch: pick a catalog template → CLI-transform → publish) that should be reconciled rather than both landing independently.Test plan
.agents/plugins/marketplace.json,.gitignore,README.mdtableau-analytics/tableau-content-viewer(read-only skills onmain) should be retained alongside this branch's authoring-focused skillsvalidate-workbook-package's referenced tools (scaffold-data-app,upsert-data-app-files,create-and-publish-workbook) actually exist on the hosted Tableau MCP server'smcp-apps/authoring tool grouppython3 -m unittest discover— 216 tests pass (lxml/pytest unavailable in review environment, but suite uses plainunittest, not pytest-specific features)