fix: normalize CRLF line endings to LF in six Python files#1816
Open
bcantoni wants to merge 3 commits into
Open
fix: normalize CRLF line endings to LF in six Python files#1816bcantoni wants to merge 3 commits into
bcantoni wants to merge 3 commits into
Conversation
Several files had CRLF line endings baked in from a prior black-version bump commit, causing ^M noise in diffs. Also reformats the multi-line .format() calls in data_alert_item.py and subscription_item.py to match current black formatting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
@jacalata @jorwoods I'm not 100% sure about this one -- it started because those 2 /models/ files were being tagged as needing to be reformatted for me, and I noticed the line ending were off. This PR works but everyone would need to be at least on Python 3.13 for Black to work correctly. Maybe we should just leave it as is for now. |
Contributor
|
Could adding an editorconfig file to the repo permit users to likely keep a lower version locally and keep the higher version in the pipeline? |
Contributor
|
Also, 3.10 deprecates and 3.15 releases in 3 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several files had CRLF line endings baked in from a prior black-version bump commit, causing ^M noise in diffs.
I think these came in accidentally in #1780