Fix large library project loading crash - #799
Merged
YukiMatsuzawa merged 2 commits intoSep 17, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
FillFromStream can still report success for incomplete reads, allowing truncated data to reach parsing or LZ4 decoding.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes large-library loading crashes by handling short stream reads before LZ4 deserialization.
Changes:
- Fills buffers across partial stream reads.
- Adds regression coverage for regular, incremental, and indexed deserialization.
File summaries
| File | Description |
|---|---|
tests/Common/CommonStandardTests/MessagePack/LargeListMessagePackTests.cs |
Adds short-read regression tests. |
src/Common/CommonStandard/MessagePack/LargeListMessagePack.cs |
Updates stream buffer filling. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+144
to
+147
| if (length <= 0) | ||
| { | ||
| return false; | ||
| } |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
YukiMatsuzawa
deleted the
copilot/yukimatsuzawa-fix-large-library-lz4-decoder
branch
September 17, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #796
Validation