Repository navigation
Clarify grammar and typos in syscall section and syscall-steal.c - #381
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
visitorckw
reviewed
Aug 22, 2026
| /* The function we will replace sys_openat (the function called when you | ||
| * call the open system call) with. To find the exact prototype, with | ||
| /* Our replacement function for sys_openat (the function called when you | ||
| * call the open system call) . To find the exact prototype, with |
Collaborator
There was a problem hiding this comment.
An extra space was accidentally introduced before the period.
Contributor
Author
There was a problem hiding this comment.
Thanks, I have updated .
Fix grammatical errors and typos in the syscall description section and the syscall-steal.c example file to improve readability.
frank0988
force-pushed
the
fix-syscall-table-sentence
branch
from
August 24, 2026 11:57
6932bb5 to
2419dea
Compare
Contributor
|
Thank @frank0988 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix grammatical errors and typos in the syscall description section and the syscall-steal.c example file to improve readability.
Summary by cubic
Clarifies terminology and fixes typos in the syscall section and example comments for accuracy; no runtime or build changes.
lkmpg.tex, explains that the syscall dispatcher changed from an indirect call table to a switch to mitigate BHI attacks.examples/syscall-steal.c, corrects thatsys_openatis a static function (not a variable), fixes “wreak havoc,” and clarifies why the original call pointer is retained.Written for commit 2419dea. Summary will update on new commits.