ci: make local e2e the merge gate - #752
piotr-iohk wants to merge 2 commits into
Conversation
Keep e2e-status as the required local check, move staging off PRs, and run migration on release-* with the same Slack summary as staging.
|
| uses: actions/checkout@v7 | ||
| with: | ||
| repository: synonymdev/bitkit-e2e-tests | ||
| ref: main |
There was a problem hiding this comment.
Mutable Script Receives Secret
The Slack report checks out scripts/slack_summary.py from the mutable bitkit-e2e-tests@main branch and then runs it with SLACK_WEBHOOK_URL_STAGING in its environment. A later change or compromise of that branch could access the webhook without a reviewed change in this repository. Pin the external repository to a reviewed commit SHA.
How this was verified: The checked-out remote script runs directly in the following step with the Slack webhook present in its process environment.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Pinning to main blocked testing slack_summary.py on a matching e2e-tests branch. Leave transfer_1 off staging until it is stable.
Related to synonymdev/bitkit-e2e-tests#221 (PR B)
This PR:
e2e-statusis local-onlye2e-staging.ymlon schedule and dispatch (no PR trigger)release-*PRs and posts the same Slack summary as stagingDescription
Staging stays off the merge gate. Feature PRs no longer wait on stag0. Local grep is
@transfer_2instead of blob@transfer. Staging shards stay@multi_address_2,@pubky,@transfer_max(@transfer_1later). Slack checkout uses the resolved e2e-tests branch so a same-named branch can testslack_summary.py.Migration:
pull_requestruns only when head or base starts withrelease-. Slack posts on schedule and on dispatch whenpost_to_slackis true, usingSLACK_WEBHOOK_URL_STAGING.Linked Issues/Tasks
synonymdev/bitkit-e2e-tests#221
Design
N/A — no UI changes.
Screenshot / Video
N/A
QA Notes
Manual Tests
N/A
Automated Checks
e2e-statuswithout staging jobs.gh workflow run e2e-staging.ymlstill works; migration on arelease-*PR should run; nightly/dispatch withpost_to_slackposts to#bitkit-staging-nightly.