-
Notifications
You must be signed in to change notification settings - Fork 3
feat: transfer to spending from HW wallet #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,271
−81
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
176ce3b
feat: Hw funding models
jvsena42 f5a674e
feat: funding methods
jvsena42 7ca7a39
feat: reconnect hardening
jvsena42 6ff0299
feat: transfer viewmodel methods
jvsena42 af75113
feat: transfer activity methods
jvsena42 e48bad9
fix: balance double counting
jvsena42 2c4a140
feat: UI logic
jvsena42 93e760a
feat: navigation
jvsena42 75ba1f0
feat: localization and asets
jvsena42 b7b520b
test: transfer tests
jvsena42 f4725fa
refactor: make code more testable
jvsena42 a522880
refactor: extract HW methods from transfer viewmodel
jvsena42 63be3e7
fix: add longer read time-out
jvsena42 2a63fa9
doc: update changelog entry
jvsena42 8122f44
Merge branch 'feat/hw-wallet-connect' into feat/hw-transfer-to-spending
jvsena42 61cb584
Merge branch 'feat/hw-wallet-connect' into feat/hw-transfer-to-spending
jvsena42 d9feafa
fix: increase timout for /call messages
jvsena42 09a148e
Merge branch 'feat/hw-wallet-connect' into feat/hw-transfer-to-spending
jvsena42 c6f5c14
Merge branch 'master' into feat/hw-transfer-to-spending
jvsena42 3b9d131
fix: display availability error on amount screen
jvsena42 1a682b7
fix: stop storing the SCID in the activity's channelId; pass nil (it'…
jvsena42 f553e8f
fix: handle compose error
jvsena42 cdd13d7
fix: mark activity as transfer atomically
jvsena42 102f858
fix: improve send marx calc for hardware wallets
jvsena42 11e1690
fix: split sign timeout from broadcast
jvsena42 5016c33
fix: guard geoblocked HW orders
jvsena42 0de59ff
fix: Disable Continue on stale HW limits
jvsena42 6a5a667
fix: handle user cancelation error
jvsena42 99f05b7
test: device cancelation tests
jvsena42 e293b49
fix: collapse HW activities duplicates
jvsena42 eff5dcf
fix: fallback to cached channelId on order fetch error
jvsena42 f215db5
fix: rerun HW limits on Blocktank info
jvsena42 cdf4112
fix: cancel hwSignTask on abandonment
jvsena42 1d13e31
fix: port android warmup logic and reconnect toast
jvsena42 ee780fa
fix: bump the iOS broadcast timeout to 120s to match Android's budget
jvsena42 2484d8d
fix: disable order mutating controls while signing to prevent change …
jvsena42 3f799c2
fix: validate rezer cancelaition error from inderlying error
jvsena42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import BitkitCore | ||
|
|
||
| extension Error { | ||
| /// Whether this error is a Trezor on-device cancellation (user declined signing, or cancelled PIN | ||
| /// / passphrase entry). Distinct from Swift `CancellationError` (the flow/task being dismissed). | ||
| /// Callers treat it as a silent no-op so the user can retry on the same screen. | ||
| func isTrezorUserCancellation() -> Bool { | ||
| if let trezorError = self as? TrezorError { | ||
| switch trezorError { | ||
| case .UserCancelled, .PinCancelled, .PassphraseCancelled: | ||
| return true | ||
| default: | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| // `ServiceQueue` boxes core errors into a generic `AppError` before they reach the caller, so | ||
| // unwrap and re-check the preserved underlying error. | ||
| if let appError = self as? AppError, let underlyingError = appError.underlyingError { | ||
| return underlyingError.isTrezorUserCancellation() | ||
| } | ||
|
|
||
| return false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.