Skip to content

feat(ui): add offline UI#528

Open
pwltr wants to merge 1 commit intomasterfrom
feat/offline-ui
Open

feat(ui): add offline UI#528
pwltr wants to merge 1 commit intomasterfrom
feat/offline-ui

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented Apr 22, 2026

Description

  • add UI for offline state in various flows
  • add connection lost/restored toast
  • improve app status logic for offline state
  • polish and refactor animated loading UI

Screenshot / Video

iPhone 17:

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-22.at.18.23.36.mov

iPhone SE:

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2026-04-22.at.18.25.27.mov

QA Notes

To test use the app while offline / in airplane mode

Comment on lines +40 to +42
Text("\(index + 1)")
.foregroundColor(index == currentStep ? Color.purpleAccent : .white32)
.font(.custom(Fonts.regular, size: 17))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAUDE.md violation: raw Text().foregroundColor().font() chain

The step number label uses a raw Text with chained .foregroundColor() and .font() modifiers, which is explicitly prohibited by CLAUDE.md:

"Use the project's text components (DisplayText, HeadlineText, TitleText, SubtitleText, BodyMText, BodyMSBText, BodySSBText, BodySText, CaptionMText, CaptionText) instead of raw Text().font().foregroundColor() chains."

The font size 17pt with Fonts.regular aligns with BodyMText. The per-step color override can still be applied on top of the text component via .foregroundColor().

Suggested change
Text("\(index + 1)")
.foregroundColor(index == currentStep ? Color.purpleAccent : .white32)
.font(.custom(Fonts.regular, size: 17))
BodyMText("\(index + 1)")
.foregroundColor(index == currentStep ? Color.purpleAccent : .white32)

Comment thread CHANGELOG.md
## [Unreleased]

### Added
- Add UI for offline state in various flows #524
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAUDE.md violation: wrong PR number in CHANGELOG entry

The changelog entry references #524 but this is PR #528. CLAUDE.md requires:

"ALWAYS append #PR_NUMBER at the end of each changelog entry when the PR number is known"

Looks like #524 was copy-pasted from the entry directly below it ("Add transfer from savings button").

Suggested change
- Add UI for offline state in various flows #524
- Add UI for offline state in various flows #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant