Repository navigation
chore: prepare 0.8.0-rc14 - #202
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
talosmachina
left a comment
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Bumps bitkitcore to 0.8.0-rc14 across Cargo.toml, Cargo.lock, Package.swift and bindings/android/gradle.properties, and swaps in the new iOS archive checksum. Reviewed bef3152, full tier (manifest and lock changes), stacked on #201's head 8215f80; #201's own code is not reviewed here.
What I checked, and 2 candidates I ruled out
Read: the whole diff against feat/regtest-auth (4 files, 5 lines), and build.sh's bump_version, which names the same three version files.
Version sync: git grep on the head finds no leftover 0.8.0-swaps or rc13 string outside Cargo.lock; all three files and the lock say 0.8.0-rc14, and the Package.swift tag is v0.8.0-rc14. No v0.8.0-rc14 tag exists yet.
CI at review time: SwiftPM manifest, Scripts/Cargo/Android manifests, paykit-route-tests and wake-tests green; iOS Bindgen, Android Bindgen and usdt-tests still pending.
Build: not built here. The version bump changes no code, and the archive cannot be checked from Linux.
Ruled out
- Version skipping or colliding:
v0.8.0-rc13is the newest rc tag andrc14is free. - Checksum mismatch: can't be checked until the release zip is published. The PR's release step 4 checks it after publishing, which is the only point where it can be checked.
Merge confidence: 4/5, the bindgen jobs were still pending and the Package.swift checksum can only be confirmed against the published archive.
|
Retargeted to master: #201 merged. |
coreyphillips
left a comment
coreyphillips
left a comment
There was a problem hiding this comment.
Two independent reviews, nothing blocking a merge.
nits
- PR body understates what is new since rc13. The description lists 'the swaps prereleases already on master (v0.8.0-swaps.7 to v0.8.0-swaps.11)' as the change since rc13.
git merge-base --is-ancestorshows that nov0.8.0-swaps.*tag is an ancestor ofv0.8.0-rc13. swaps.1, .2, .5 and .6 are also on master and are ancestors of swaps.7. So everything from swaps.1 onward, the whole pubky swaps route, is new in rc14. Release notes copied from this list would suggest swaps.1 to .6 shipped in an earlier rc, which they did not. Suggest saying 'the pubky swaps route (#182, prereleased as v0.8.0-swaps.1 to .11)'.
|
@coreyphillips right, none of the swaps prereleases is in rc13. The description now lists the whole pubky swaps route (#182, prereleased as |
coreyphillips
left a comment
coreyphillips
left a comment
There was a problem hiding this comment.
Rechecked after replies, with no new commit since bef3152. Nothing blocking remains.
addressed
- PR body understates what is new since rc13. Fixed:
gh pr view 202now lists "The pubky swaps route (#182, prereleased asv0.8.0-swaps.1tov0.8.0-swaps.11)" as new since rc13. I re-rangit merge-base --is-ancestorfor everyv0.8.0-swaps.*tag againstv0.8.0-rc13, and none of them is an ancestor, so the new wording is accurate.
|
@coreyphillips I merged master into this PR after #203 merged and rebuilt the iOS archive. The only change in |
|
Merged: approved by @coreyphillips on |
|
Released: https://github.com/synonymdev/bitkit-core/releases/tag/v0.8.0-rc14. The signed tag is on the merge commit |
Released as https://github.com/synonymdev/bitkit-core/releases/tag/v0.8.0-rc14 (signed tag on merge commit
8fbf1d7, tree identical to0ccfdb8).Prepares
0.8.0-rc14so both apps can pass Blocktank regtest auth to the regtest calls (#201). Both apps pin0.8.0-rc11; master's API since then is additive (wake, swaps, Paykit route, RBF records).This branch includes master after #203 (review fixes for #201), and the iOS archive is rebuilt on that tree, so the tag matches.
Description
Changes since
v0.8.0-rc13:regtest_mine,regtest_deposit,regtest_pay,regtest_get_paymentandregtest_close_channeltake an optionalauth(user:password), sent as basic auth to Blocktank servers that protect the regtest routes; a 401 returns a clear error. Credentials in the base URL are never shown in errors or sent twice, and a base URL with a query string keeps the regtest path. (feat: basic auth on regtest calls #201, fix: hide credentials in regtest errors #203)v0.8.0-swaps.1tov0.8.0-swaps.11).This PR changes only the version in
Cargo.toml,Cargo.lock,Package.swiftandbindings/android/gradle.properties, plus the iOS checksum inPackage.swift. The regenerated Swift interface files match master.The iOS archive was built with
./build_ios.shon Rust 1.91.1 (the crate'srust-version) and Xcode 27.0. It is 109,666,264 bytes, SHA-256e9b2cd393cd31e0bf933947567e4c6d77511215b13048b21f26ce01a90732b27, matchingPackage.swift. Android coordinates arecom.synonym:bitkit-core-android:0.8.0-rc14.Release steps after merge
v0.8.0-rc14on the merge commit and publish the release with the preservedBitkitCore.xcframework.zip. Publishing runsgradle-publish.yml, which builds and publishes the Android package.Package.swiftand that the Android package resolves before bumping app pins.QA Notes
Candidate:
0ccfdb8on masterf69c298../build_ios.sh: passed. The regenerated Swift interface files are identical to master's.swift package compute-checksumon the archive matchesPackage.swift.BLOCKTANK_REGTEST_AUTHset, and fails at once with the 401 error without it.