Conversation
|
Same as pubky/paykit-rs#153 and synonymdev/vss-rust-client-ffi#11 |
There was a problem hiding this comment.
Verdict: ✅ Approve
Review: diff 13 files.
Findings:
1 inline (non-blocking)
Security audit skipped - no security surface in the diff (score 0, threshold 3)
Reviewed by opus-xhigh via gh-pr-review-loop skill
| - '**/Cargo.toml' | ||
| - '**/Package.swift' | ||
| - '**/bindings/ios/**' | ||
| - '**/build*.sh' |
There was a problem hiding this comment.
The filter covers **/build*.sh and **/Package.swift, but not update_package.py, the script build_ios.sh line 113 invokes to write the checksum and tag values that Package.swift turns into the binary target URL. A change there that breaks the substitution would merge without this workflow running, surfacing only when a release is cut. Could we add update_package.py to both the pull_request and push path lists?
Summary
See #114
Validation