Skip to content

chore: clean up generated mobile artifacts - #154

Open
pwltr wants to merge 1 commit into
masterfrom
chore/mobile-bindgen-cleanup
Open

pwltr wants to merge 1 commit into
masterfrom
chore/mobile-bindgen-cleanup

Conversation

@pwltr

@pwltr pwltr commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add split iOS, Android, and lightweight bindgen validation workflows
  • stop tracking generated Android Kotlin bindings and iOS XCFramework release payloads
  • generate iOS XCFramework artifacts under dist/ios with deterministic zip metadata
  • document and ignore generated mobile binary outputs

See #114

Validation

  • ruby -e "require 'yaml'; Dir['.github/workflows/*.{yml,yaml}'].sort.each { |f| YAML.load_file(f); puts "ok #{f}" }"
  • bash -n build.sh build_ios.sh build_android.sh build_python.sh
  • git diff --check
  • cargo metadata --locked --format-version 1
  • swift package dump-package
  • ./gradlew projects --no-daemon

@pwltr

pwltr commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve


Review: diff 13 files.

Findings:
1 inline (non-blocking)
Security audit skipped - no security surface in the diff (score 0, threshold 3)


Reviewed by opus-xhigh via gh-pr-review-loop skill

- '**/Cargo.toml'
- '**/Package.swift'
- '**/bindings/ios/**'
- '**/build*.sh'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter covers **/build*.sh and **/Package.swift, but not update_package.py, the script build_ios.sh line 113 invokes to write the checksum and tag values that Package.swift turns into the binary target URL. A change there that breaks the substitution would merge without this workflow running, surfacing only when a release is cut. Could we add update_package.py to both the pull_request and push path lists?

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants