[ovitrif]

Closes #1875

Twin: synonymdev/bitkit-ios#1295

Updates bitkit-core to 0.8.0-rc15, which updates LDK's lightning crate to 0.2.8 and lightning-invoice to 0.34.2 (synonymdev/bitkit-core#207).

Description

• Bumps bitkit-core from 0.8.0-rc14 to 0.8.0-rc15, a dependency-update release with no API changes.
• The upgraded crates are used only by bitkit-core's Boltz swap module (boltz-client), so the new code runs in submarine and reverse swaps: create, claim and refund. Invoice decoding (decode) still uses bitkit-core's lightning-invoice 0.32, unchanged.
• No changelog fragment: the only parsing change rejects a BOLT11 invoice of 18,446,745 BTC or more without an SI prefix, which no real swap uses, so users see no change.
• v3.1.0 ships bitkit-core 0.8.0-rc11, so taking this into a 3.1.x patch also brings the rc12–rc14 changes: BIP21 and fee-rate fixes, trezor-connect-rs 10.0.1, the wake client, the Paykit router with its swaps route, and regtest auth.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

• com.synonym:bitkit-core-android:0.8.0-rc15 is published to GitHub Packages; CI resolves and builds it on this head.
• CI unit and E2E checks run on this head.

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-11T19:48:24.645172Z	2989dd5	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The dependency update appears safe to merge.

Summary

Updates bitkit-core-android from 0.8.0-rc14 to 0.8.0-rc15.

• The Android app now uses bitkit-core 0.8.0-rc15.

_{Reviews (1) · Last reviewed commit: "chore: bump bitkit-core to 0.8.0-rc15" · Reviewed by Greptile}

[github-actions]

Regtest APK

Built from 2ec5511 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

[talosmachina]

No findings. Bumps bitkit-core from 0.8.0-rc14 to 0.8.0-rc15 and adds a changelog fragment. Reviewed bca1bdb, full tier (dependency manifest), static: on this repo the branch is not built here, so this rests on the code and CI.

What I checked, and 2 candidates I ruled out

Read in full: both changed files; gradle/libs.versions.toml around the pin.
Upstream delta: synonymdev/bitkit-core compare v0.8.0-rc14...v0.8.0-rc15 is two commits touching CHANGELOG.md, Cargo.toml, Cargo.lock, Package.swift and bindings/android/gradle.properties. The only dependency moves are lightning 0.2.3 -> 0.2.8, lightning-invoice 0.34.1 -> 0.34.2 and lightning-types 0.3.2 -> 0.3.5. No source or binding changes, so the generated Kotlin API is unchanged.
Artifact: the Gradle Package workflow on tag v0.8.0-rc15 succeeded, and the bindgen, Android bindgen and test workflows on the release branch were green.
CI on this head: build-and-test passed (it resolves com.synonym:bitkit-core-android:0.8.0-rc15 and runs the unit tests). lint, build-local and compose-ui / ui-tests were still pending when I looked.

Ruled out

• LDK version clash with ldk-node-android: bitkit-core and ldk-node ship as separate native libraries, each statically linking its own lightning crate behind its own UniFFI surface, so a different patch version in one does not touch the other.
• Hidden API change across rc14 -> rc15: the compare has no src/ or binding edits, only the version strings and lockfile.

Merge confidence: 4/5, no findings, but lint and the UI tests had not finished on this head when I reviewed it.

[coreyphillips]

Two independent reviews, nothing blocking a merge.

nits

• Changelog fragment under Fixed names no user-visible fix (changelog.d/next/1876.fixed.md:1)

[coreyphillips]

Rechecked after 1 new commit (2ec5511). Nothing blocking remains.

addressed

• Changelog fragment under Fixed names no user-visible fix (changelog.d/next/1876.fixed.md:1). Fixed: changelog.d/next/1876.fixed.md:1 now names the user-visible change instead of the library update. I diffed the lightning-invoice 0.34.1 and 0.34.2 sources. In 0.34.1, a BOLT11 amount with no SI prefix that overflows checked_mul makes amount_pico_btc return None, so the invoice reads as amountless. In 0.34.2, RawHrp::from_str returns IntegerOverflowError for it. Bitkit decodes invoices through bitkit-core's decode (CoreService.kt:209), so the sentence holds for the app.

[ovitrif]

Bitkit decodes invoices through bitkit-core's decode (CoreService.kt:209), so the sentence holds for the app.

@coreyphillips That path uses bitkit-core's own lightning-invoice 0.32.0 (Cargo.toml:20, scanner/implementation.rs), which rc15 leaves unchanged; 0.34.2 only reaches boltz-client, which already rejects amountless invoices. So rc15 changes nothing a user sees, and aeef10a drops the fragment, per the repo's rule for chore: PRs. The iOS twin drops it too.

[coreyphillips]

Rechecked after 1 new commit (aeef10a). Nothing blocking remains.

[ovitrif]

Cancelled the CI run for the superseded head 2ec5511 (https://github.com/synonymdev/bitkit-android/actions/runs/43094162621) so the runs for aeef10a, the current head, can start.