Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1259
This PR makes the Send confirm screen use the blue hardware accent when the funding source is a hardware wallet, instead of the orange on-chain accent.
Description
The accent now matches iOS, where the same screen already returns the blue accent while a hardware send is active, and matches the funding-source chip on this screen, which has always been blue for hardware.
Design
Reporting an honest conflict rather than a clean match. The hardware variant of this screen is designed in Send (Hardware Device) (On-chain) › Confirm Send Onchain and › Confirm Send Onchain Details on Handoff v62. Both frames show the swipe slider, the speed-and-fee icon and the details icon in the orange on-chain accent, with only the FROM chip in blue — which is what Android shipped and what this PR changes.
The change follows the issue and iOS instead of those frames. Worth a designer call on which one is correct before this merges; if the frames are the intended behaviour, this PR should be closed and the issue reclassified rather than merged.
Related: #1201, #1203, #998.
Preview
QA Notes
Manual Tests
regression:Confirm → switch funding source back to Savings: slider and details icon return to orange.regression:Send a LN invoice → Confirm: slider and details icon stay purple.regression:Hardware Confirm → swipe to pay: signing flow starts as before; no behaviour change beyond color.Automated Checks
SendConfirmScreenTest.kt: render the confirm screen and count accent pixels in the captured bitmap, asserting blue with a hardware funding source and orange without one. Verified the blue test fails against the pre-fix accent logic and passes after it, on a Pixel 9 emulator.just compile,just test, andjust lintpass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01KavTcT18zALriWtzY57GTR