Repository navigation
Conversation
krodak
approved these changes
Oct 14, 2026
| printer.write("const reject = \(s).memory.getObject(rejectRef);") | ||
| printer.write(contentsOf: body) | ||
| printer.write("try {") | ||
| printer.indent { |
Member
There was a problem hiding this comment.
The doc comment above renderAsyncFunction still says the body "chains .then(resolve, reject) on the import's returned Promise". With this change it goes through Promise.resolve(...), and a synchronous throw ends up in reject. I'd just drop that last part rather than reword it. The body is ten lines, and a description of it will drift again next time:
/// Renders an async import function with resolve/reject closure refs.
///
/// The generated function takes `resolveRef` and `rejectRef` as the first parameters
/// and settles them with the result of the import call.
Member
|
Thanks, this is great 🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it so you can implement protocol methods which are
asyncandthrows(JSException)in JS. This also fixes a bug where JS exceptions thrown synchronously in async functions were not handled, and allows a non-Promise return (likeawait).