Skip to content

fix(sv-utils): dedupe re-homed comments at attach time#1154

Open
jycouet wants to merge 1 commit into
feat/sv-migratefrom
fix/migrate-comment-dup
Open

fix(sv-utils): dedupe re-homed comments at attach time#1154
jycouet wants to merge 1 commit into
feat/sv-migratefrom
fix/migrate-comment-dup

Conversation

@jycouet

@jycouet jycouet commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Drop one positional copy from the original list when a comment is
attached to a node, so esrap doesn't emit it from both channels.
@changeset-bot

changeset-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f6db281

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@manuel3108 manuel3108 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any change in the pkg.svelte.dev repo.
Running pnpx --config.block-exotic-subdeps=false https://pkg.svelte.dev/sv/c/f6db281 migrate

still changes src/lib/github.ts by duplicating comments.

Since the repo is not public, i wont share too much code, but i think this should make it reproducable.

export async function list_recent_pulls(
	opts: { 
		/**
		 * Octokit to authenticate the REST call. Pass an
		 * `octokit_for_user(...)` instance from a remote function so the
		 * request counts against the user's GitHub budget, not the
		 * App-installation budget.
		 */
		octokit: Octokit;
		owner: string;
		repo: string;
		per_page?: number;
		page?: number
	 }
): Promise<PullSummary[]> { /* ... */ }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants