feat: reborn app-state migration#1148
Merged
Merged
Conversation
- @migration-task comments now work in .svelte files (insert real Comment
nodes into the fragment, since the Svelte printer ignores the JS Comments
registry); fixes the env task silently dropping them.
- single addMigrationTask(message, target): { comments, node } for JS/TS,
{ fragment, anchor? } for .svelte.
- split migrate/index.ts into index.ts (framework) + migration-task.ts.
|
jycouet
force-pushed
the
feat/app-state-migration
branch
from
0639911 to
f31ac69
Compare
Rebuild `$app/stores` -> `$app/state` as a proper AST task instead of the
regex legacy shell-out. Runnable standalone (`sv migrate app-state`) and
required inside the sveltekit-3 migration.
Bug fixes over the legacy version:
- truthy `$navigating` (e.g. {#if $navigating}) -> `navigating.to`
- bail cases (`$:`, `derived(store)`, `getStores()`) now leave a @migration-task instead of silently skipping
- drop spurious TODO when `.to` is already accessed
jycouet
force-pushed
the
feat/app-state-migration
branch
from
f31ac69 to
55fc80c
Compare
jycouet
changed the base branch from
feat/sv-migrate
to
feat/svelte-migration-comments
Base automatically changed from
feat/svelte-migration-comments
to
feat/sv-migrate
June 26, 2026 03:24
…tate-migration # Conflicts: # packages/sv/src/cli/migrate.ts
manuel3108
approved these changes
Jun 27, 2026
manuel3108
left a comment
manuel3108
left a comment
Member
There was a problem hiding this comment.
LGTM, even found some more places to migrate in immich, the previous migration did not find / bailed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the
$app/stores->$app/statemigration as a proper AST task (was a regex legacy shell-out).sv migrate app-statesveltekit-3migrationBug fixes over the legacy version:
$navigating(e.g.{#if $navigating}) ->navigating.to$:,derived(store),getStores()) now leave a@migration-taskinstead of silently skipping.tois already accessedStacked on #1147 (uses its shared
addMigrationTask); merge that first.