feat(prettier): generate prettier.config.{js,ts} instead of .prettierrc#1145
Draft
jycouet wants to merge 2 commits into
Draft
feat(prettier): generate prettier.config.{js,ts} instead of .prettierrc#1145jycouet wants to merge 2 commits into
jycouet wants to merge 2 commits into
Conversation
…`.prettierrc`, giving type-checked config and editor autocompletion
🦋 Changeset detectedLatest commit: 93803ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
This works as expected. Any reason this is still a draft? If not, please see this as an approval! |
Contributor
Author
|
In the past I had issues with vscode prettier plugin that couldn't figure out |
Drop the `.ts` config variant. A `prettier.config.ts` can't be loaded by the VSCode prettier extension unless its Electron Node is recent enough to strip types (see prettier/prettier-vscode#3989), so emit `.js` with a JSDoc `@type` for every project - works in the CLI, CI and editors alike.
Contributor
Author
|
I think that |
Contributor
|
I am fine as long as the config supports type checking. I mean we've been limited to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1095
Description
Replaces the
.prettierrcJSON file with a generatedprettier.config.js(with a JSDoc@type {import("prettier").Config}), giving editor autocompletion on the config..js, even for TS projects: aprettier.config.tscan't be loaded by the VSCode prettier extension unless its Electron Node is recent enough to strip types (see prettier/prettier-vscode#3989). A.jsconfig resolves everywhere - CLI, CI and editors.tailwindcssaugments the config (plugin +tailwindStylesheet) when prettier was added first.Checklist